Repository navigation
build(deps): upgrade Electron 29 -> 45 and move to Node 24 - #136
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 36.87% 36.84% -0.04%
==========================================
Files 116 117 +1
Lines 4301 4310 +9
Branches 1038 1038
==========================================
+ Hits 1586 1588 +2
- Misses 2509 2518 +9
+ Partials 206 204 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
raphaelcoeffic
force-pushed
the
deps/electron-upgrade
branch
from
March 7, 2026 05:03
7d643e5 to
00ce114
Compare
Deploying buddy with
|
| Latest commit: |
d5ea932
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae9be7fb.buddy-7a6.pages.dev |
| Branch Preview URL: | https://head.buddy-7a6.pages.dev |
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
raphaelcoeffic
force-pushed
the
deps/electron-upgrade
branch
from
March 7, 2026 05:20
00ce114 to
d5ea932
Compare
This was referenced Nov 17, 2026
Upgrade date-fns 2->4, uuid 9->11, semver 7.3->7.7, debounce 1->2, nanoevents 6->9, and bump matching @types/* packages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Upgrade electron to ^35, electron-builder to ^25, @electron/rebuild to ^3.7 - Upgrade electron-devtools-installer to ^4 and remove APOLLO_DEVELOPER_TOOLS (no longer exported in v4) - Requires manual app testing to verify USB native module and window behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- electron ^35 -> ^45.3.3 (35 is end-of-life; 43-45 are supported) - electron-builder ^26.8.1 -> ^26.18.0 - @electron/rebuild ^4.0.3 -> ^4.2.1 - Pin date-fns to ~4.1.0: 4.4.0's type declarations import "./x.ts" paths that TypeScript 4.9 cannot resolve Electron 44+ requires macOS 13 (Ventura) or later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Replace the single date-fns `format(ms, "mm:ss")` call with a small formatElapsed helper. This removes the ~4.1.0 pin (newer date-fns typings need a newer TypeScript) and fixes the elapsed time showing wrong minutes in timezones with half-hour offsets, as `format` interpreted the duration as a local time of day. Minutes also no longer wrap after an hour. - Inline the minimize/close IPC from electron-window-controls. It declared electron@^12 as a regular dependency, so every install pulled in a second Electron. Handlers are now registered once at startup rather than on every window creation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- .node-version 22.23.5 -> 24.22.3 (also used by the devcontainer), and CI node-version "22" -> "24" - @types/node ^20 -> ^24, matching the Node bundled with Electron 45 - tsconfig lib es2021 -> es2022 to match target. Code already uses Array.prototype.at(), which only type-checked because @types/node 20 declared it globally. - Refresh @typescript-eslint/* within ^5 (5.6.0 -> 5.62.0); 5.6 does not recognise the es2022 lib - Refresh Yarn's implicit node-gyp@latest (8.4.0 -> 13.1.0), used to build fsevents on macOS, and drop the Python 3.9 + setuptools CI pin that node-gyp 8 needed for distutils Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Drop python3-setuptools from the devcontainer; it was only needed for node-gyp 8's distutils. python3 stays, node-gyp still requires it. - Install Corepack in the devcontainer if Node doesn't bundle it (Node 25+ no longer does), so bumping .node-version keeps working - README: node@22 -> node@24, drop python3-setuptools from the prerequisites, and replace the Node <16.10 Corepack instructions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
force-pushed
the
deps/electron-upgrade
branch
from
November 18, 2026 08:34
d5ea932 to
4791952
Compare
First version change since the project started. Marks the move to Electron 45 / Node 24 and the new macOS 13 minimum, and lets Windows MSI installers recognise newer builds as upgrades. Installer file names include the version, so assets in the rolling `latest` release change from edgetx-buddy-0.1.0.* to edgetx-buddy-0.2.0.*. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Electron 29 → 45 (35 is already end-of-life; 43–45 are the supported majors), moves the toolchain to Node 24 LTS, and drops dependencies that no longer pull their weight. Rebased onto current
main(after the Yarn 4 upgrade in #160); this absorbs the follow-up PRs #161 and #162.Commits
Raphael Coeffic
chore: upgrade utility packages(date-fns 2→4, uuid 9→11, semver 7.3→7.7, debounce 1→2, nanoevents 6→9, plus matching@types/*)chore: upgrade Electron 29 -> 35 and related packages(electron ^35, electron-builder ^26, @electron/rebuild ^4, electron-devtools-installer ^4; Apollo devtools removed as v4 no longer exports it)Peter Feerick
build(deps): upgrade Electron 35 to 45: electron ^45.3.3, electron-builder ^26.18.0, @electron/rebuild ^4.2.1refactor(deps): drop date-fns and electron-window-controlsformat(ms, "mm:ss")call; newer 4.x typings need TypeScript 5. Replaced with a testedformatElapsedhelper, which also fixes wrong minutes in half-hour-offset timezones (e.g. India) and minutes wrapping after an hour.src/main/windowControls.ts). It declaredelectron@^12as a regular dependency, so every install pulled in a second Electron. Handlers are now registered once at startup rather than per window creation.build: move to Node 24 LTS.node-version24.22.3 and CInode-version: "24";@types/node^24tsconfiglibes2021 → es2022 (matchestarget;Array.prototype.at()was only type-checking via@types/node20)@typescript-eslint/*refreshed within ^5 (5.62.0) to acceptes2022node-gyp@latestrefreshed 8.4.0 → 13.1.0, which lets CI drop the Python 3.9 + setuptools pin (node-gyp 8 neededdistutils)docs: update devcontainer and README for Node 24: droppython3-setuptools, install Corepack if Node doesn't bundle it (Node 25+), README Node/Corepack instructionschore: bump version to 0.2.0: first version change since 0.1.0; also lets Windows MSI installers recognise newer builds as upgradesEach commit's
yarn.lockwas regenerated with Yarn 4 during the rebase (date-fns held at the 4.1.0 Raphael tested until commit 4 removes it).defaultPath.latestrelease becomeedgetx-buddy-0.2.0.*. Direct links to…/releases/download/latest/edgetx-buddy-0.1.0.*(website, docs, pinned messages) will break; links to the release page are unaffected.Electron 36–45 breaking-changes review
Nothing required code changes beyond the above:
requireselectron, so Electron 45's sandboxed-preload shim removal (Buffer,events,timers,url) doesn't apply.app.commandLineswitches used are already lowercase (Electron 36 lowercases them).Testing
Locally on Windows with Node 24, clean install:
yarn install --immutable,fmt:check,test:types,lint:all(0 errors),compile:productionpassexecSync("node -e …")quoting undercmd.exe, absolute paths in an sdcard snapshot); CI runs these on Linuxusbnative module loaded; minimize/close IPC verified by driving the app with the repo's Playwright 1.29 (so the e2e tooling still works with Electron 45)Manual testing done (@pfeerick):
formatElapsed) showing correctlyStill to test:
Note on macOS signing
build-and-test-app (macos-latest)has been failing onmainsince 17 Nov at the code-signing step (security set-key-partition-list, electron-builder 24.13.3 on themacos-26-arm64image). That started before this PR and isn't caused by it. Signing only runs on pushes tomain/tags, so this PR's CI can't show whether electron-builder 26 fixes it.🤖 Generated with Claude Code